From d23bf0a14441e8642872e934f099af001ea2106b Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Tue, 12 Feb 2019 13:59:16 -0500
Subject: [PATCH 01/10] change product name, include version string

---
 targets/stm32l432/bootloader/bootloader.h | 17 ++++++++++++-----
 targets/stm32l432/lib/usbd/usbd_desc.c    | 15 +++------------
 targets/stm32l432/src/app.h               | 10 ++++++++++
 3 files changed, 25 insertions(+), 17 deletions(-)

diff --git a/targets/stm32l432/bootloader/bootloader.h b/targets/stm32l432/bootloader/bootloader.h
index 22e5db3..d12d953 100644
--- a/targets/stm32l432/bootloader/bootloader.h
+++ b/targets/stm32l432/bootloader/bootloader.h
@@ -1,21 +1,21 @@
 /*
  * Copyright (C) 2018 SoloKeys, Inc. <https://solokeys.com/>
- * 
+ *
  * This file is part of Solo.
- * 
+ *
  * Solo is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
  * (at your option) any later version.
- * 
+ *
  * Solo is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with Solo.  If not, see <https://www.gnu.org/licenses/>
- * 
+ *
  * This code is available under licenses for commercial use.
  * Please contact SoloKeys for more information.
  */
@@ -65,6 +65,13 @@
 #define SKIP_BUTTON_CHECK_WITH_DELAY        0
 #define SKIP_BUTTON_CHECK_FAST              1
 
+
+#define BOOT_VERSION_MAJ    1
+#define BOOT_VERSION_MIN    0
+#define __STR_HELPER(x) #x
+#define __STR(x) __STR_HELPER(x)
+#define SOLO_PRODUCT_NAME "Solo Bootloader " __STR(BOOT_VERSION_MAJ) "." __STR(BOOT_VERSION_MIN)
+
 void printing_init();
 void hw_init(void);
 
diff --git a/targets/stm32l432/lib/usbd/usbd_desc.c b/targets/stm32l432/lib/usbd/usbd_desc.c
index bd0ed90..88b920d 100644
--- a/targets/stm32l432/lib/usbd/usbd_desc.c
+++ b/targets/stm32l432/lib/usbd/usbd_desc.c
@@ -53,19 +53,10 @@
 #define USBD_VID                        0x0483
 #define USBD_PID                        0xA2CA
 #define USBD_LANGID_STRING              0x409
-#ifndef SOLO_HACKER
-#define USBD_MANUFACTURER_STRING        "Solo Keys"
-#define USBD_PRODUCT_FS_STRING          "Solo"
-#ifndef USBD_SERIAL_NUM
+#define USBD_MANUFACTURER_STRING        "SoloKeys"
+#define USBD_PRODUCT_FS_STRING          SOLO_PRODUCT_NAME
 #define USBD_SERIAL_NUM                 "0123456789ABCDEF"
-#endif
-#else
-#define USBD_MANUFACTURER_STRING        "Solo Keys"
-#define USBD_PRODUCT_FS_STRING          "Solo HACKER (Unlocked)"
-#ifndef USBD_SERIAL_NUM
-#define USBD_SERIAL_NUM                 "0123456789ABCDEF"
-#endif
-#endif
+
 
 uint8_t *USBD_HID_DeviceDescriptor(USBD_SpeedTypeDef speed, uint16_t *length);
 uint8_t *USBD_HID_LangIDStrDescriptor(USBD_SpeedTypeDef speed, uint16_t *length);
diff --git a/targets/stm32l432/src/app.h b/targets/stm32l432/src/app.h
index 1da200d..8ffe43e 100644
--- a/targets/stm32l432/src/app.h
+++ b/targets/stm32l432/src/app.h
@@ -43,6 +43,16 @@
 // #define DISABLE_CTAPHID_PING
 // #define DISABLE_CTAPHID_WINK
 // #define DISABLE_CTAPHID_CBOR
+#define SOLO_VERSION_MAJ    1
+#define SOLO_VERSION_MIN    0
+#define __STR_HELPER(x) #x
+#define __STR(x) __STR_HELPER(x)
+
+#if defined(SOLO_HACKER)
+#define SOLO_PRODUCT_NAME "Solo Hacker " __STR(SOLO_VERSION_MAJ) "." __STR(SOLO_VERSION_MIN)
+#else
+#define SOLO_PRODUCT_NAME "Solo " __STR(SOLO_VERSION_MAJ) "." __STR(SOLO_VERSION_MIN)
+#endif
 
 void printing_init();
 void hw_init(void);

From 8303bb04d3617a5a92ed8553e5c323c0b1be3059 Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Tue, 12 Feb 2019 13:59:36 -0500
Subject: [PATCH 02/10] write bootloader version from bootloader

---
 targets/stm32l432/bootloader/bootloader.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/targets/stm32l432/bootloader/bootloader.c b/targets/stm32l432/bootloader/bootloader.c
index 824bcf0..d8a8b1b 100644
--- a/targets/stm32l432/bootloader/bootloader.c
+++ b/targets/stm32l432/bootloader/bootloader.c
@@ -1,21 +1,21 @@
 /*
  * Copyright (C) 2018 SoloKeys, Inc. <https://solokeys.com/>
- * 
+ *
  * This file is part of Solo.
- * 
+ *
  * Solo is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
  * (at your option) any later version.
- * 
+ *
  * Solo is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with Solo.  If not, see <https://www.gnu.org/licenses/>
- * 
+ *
  * This code is available under licenses for commercial use.
  * Please contact SoloKeys for more information.
  */
@@ -191,8 +191,10 @@ int bootloader_bridge(int klen, uint8_t * keyh)
         case BootVersion:
             has_erased = 0;
             printf1(TAG_BOOT, "BootVersion.\r\n");
+            version = BOOT_VERSION_MAJ;
+            u2f_response_writeback(&version,1);
+            version = BOOT_VERSION_MIN;
             u2f_response_writeback(&version,1);
-            return 0;
             break;
         case BootReboot:
             printf1(TAG_BOOT, "BootReboot.\r\n");

From eb2d377ffbf25c471b2af5fe17a4ae51af897c1d Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Tue, 12 Feb 2019 14:00:05 -0500
Subject: [PATCH 03/10] add extension to solo to get version and RNG

---
 fido2/extensions/extensions.c    | 13 +++---
 fido2/extensions/solo.c          | 76 ++++++++++++++++++++++++++++++++
 fido2/extensions/solo.h          | 27 ++++++++++++
 targets/stm32l432/application.mk |  1 +
 4 files changed, 112 insertions(+), 5 deletions(-)
 create mode 100644 fido2/extensions/solo.c
 create mode 100644 fido2/extensions/solo.h

diff --git a/fido2/extensions/extensions.c b/fido2/extensions/extensions.c
index ad8e660..7d413c2 100644
--- a/fido2/extensions/extensions.c
+++ b/fido2/extensions/extensions.c
@@ -1,21 +1,21 @@
 /*
  * Copyright (C) 2018 SoloKeys, Inc. <https://solokeys.com/>
- * 
+ *
  * This file is part of Solo.
- * 
+ *
  * Solo is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
  * (at your option) any later version.
- * 
+ *
  * Solo is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with Solo.  If not, see <https://www.gnu.org/licenses/>
- * 
+ *
  * This code is available under licenses for commercial use.
  * Please contact SoloKeys for more information.
  */
@@ -23,6 +23,7 @@
 #include "extensions.h"
 #include "u2f.h"
 #include "wallet.h"
+#include "solo.h"
 #include "device.h"
 
 #include "log.h"
@@ -69,6 +70,8 @@ int16_t bridge_u2f_to_extensions(uint8_t * _chal, uint8_t * _appid, uint8_t klen
     ret = bootloader_bridge(klen, keyh);
 #elif  defined(WALLET_EXTENSION)
     ret = bridge_u2f_to_wallet(_chal, _appid, klen, keyh);
+#else
+    ret = bridge_u2f_to_solo(_chal, _appid, klen, keyh);
 #endif
 
     if (ret != 0)
diff --git a/fido2/extensions/solo.c b/fido2/extensions/solo.c
new file mode 100644
index 0000000..9072588
--- /dev/null
+++ b/fido2/extensions/solo.c
@@ -0,0 +1,76 @@
+/*
+ * Copyright (C) 2018 SoloKeys, Inc. <https://solokeys.com/>
+ *
+ * This file is part of Solo.
+ *
+ * Solo is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Solo is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Solo.  If not, see <https://www.gnu.org/licenses/>
+ *
+ * This code is available under licenses for commercial use.
+ * Please contact SoloKeys for more information.
+ */
+
+#include <stdint.h>
+#include "extensions.h"
+#include "u2f.h"
+#include "wallet.h"
+#include "device.h"
+#include "ctap.h"
+#include "ctap_errors.h"
+
+#include "log.h"
+#include APP_CONFIG
+
+int16_t bridge_u2f_to_solo(uint8_t * _chal, uint8_t * _appid, uint8_t klen, uint8_t * keyh)
+{
+    static uint8_t msg_buf[72];
+    int reqlen = klen;
+    int i;
+    int8_t ret = 0;
+
+    wallet_request * req = (wallet_request *) msg_buf;
+
+    printf1(TAG_WALLET, "u2f-solo [%d]: ", reqlen); dump_hex1(TAG_WALLET, msg_buf, reqlen);
+
+    switch(req->operation)
+    {
+        case WalletVersion:
+            msg_buf[0] = SOLO_VERSION_MAJ;
+            msg_buf[0] = SOLO_VERSION_MIN;
+            u2f_response_writeback((uint8_t*)WALLET_VERSION, sizeof(WALLET_VERSION)-1);
+            break;
+        case WalletRng:
+            printf1(TAG_WALLET,"SoloRng\n");
+
+            ret = ctap_generate_rng(msg_buf, 72);
+            if (ret != 1)
+            {
+                printf1(TAG_WALLET,"Rng failed\n");
+                ret = CTAP2_ERR_PROCESSING;
+                goto cleanup;
+            }
+            ret = 0;
+
+            u2f_response_writeback((uint8_t *)msg_buf,72);
+            break;
+
+        default:
+            printf2(TAG_ERR,"Invalid wallet command: %x\n",req->operation);
+            ret = CTAP1_ERR_INVALID_COMMAND;
+            break;
+    }
+
+cleanup:
+
+    return ret;
+}
diff --git a/fido2/extensions/solo.h b/fido2/extensions/solo.h
new file mode 100644
index 0000000..04e9d8d
--- /dev/null
+++ b/fido2/extensions/solo.h
@@ -0,0 +1,27 @@
+/*
+ * Copyright (C) 2018 SoloKeys, Inc. <https://solokeys.com/>
+ *
+ * This file is part of Solo.
+ *
+ * Solo is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Solo is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Solo.  If not, see <https://www.gnu.org/licenses/>
+ *
+ * This code is available under licenses for commercial use.
+ * Please contact SoloKeys for more information.
+ */
+#ifndef SOLO_H_
+#define SOLO_H_
+
+int16_t bridge_u2f_to_solo(uint8_t * _chal, uint8_t * _appid, uint8_t klen, uint8_t * keyh);
+
+#endif
diff --git a/targets/stm32l432/application.mk b/targets/stm32l432/application.mk
index 89ece0d..acc3e48 100644
--- a/targets/stm32l432/application.mk
+++ b/targets/stm32l432/application.mk
@@ -13,6 +13,7 @@ SRC += $(wildcard lib/*.c) $(wildcard lib/usbd/*.c)
 SRC += ../../fido2/util.c ../../fido2/u2f.c ../../fido2/test_power.c
 SRC += ../../fido2/stubs.c ../../fido2/log.c  ../../fido2/ctaphid.c  ../../fido2/ctap.c
 SRC += ../../fido2/ctap_parse.c ../../fido2/main.c
+SRC += ../../fido2/extensions/extensions.c ../../fido2/extensions/solo.c
 
 # Crypto libs
 SRC += ../../crypto/sha256/sha256.c ../../crypto/micro-ecc/uECC.c ../../crypto/tiny-AES-c/aes.c

From ba4f9ed7ae1a3cd33e61a32cf29dcb59417abb5e Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Tue, 12 Feb 2019 15:00:01 -0500
Subject: [PATCH 04/10] bug fix

---
 fido2/extensions/solo.c     | 8 ++++----
 targets/stm32l432/src/app.h | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/fido2/extensions/solo.c b/fido2/extensions/solo.c
index 9072588..32be8e4 100644
--- a/fido2/extensions/solo.c
+++ b/fido2/extensions/solo.c
@@ -38,16 +38,16 @@ int16_t bridge_u2f_to_solo(uint8_t * _chal, uint8_t * _appid, uint8_t klen, uint
     int i;
     int8_t ret = 0;
 
-    wallet_request * req = (wallet_request *) msg_buf;
+    wallet_request * req = (wallet_request *) keyh;
 
-    printf1(TAG_WALLET, "u2f-solo [%d]: ", reqlen); dump_hex1(TAG_WALLET, msg_buf, reqlen);
+    printf1(TAG_WALLET, "u2f-solo [%d]: ", reqlen); dump_hex1(TAG_WALLET, keyh, reqlen);
 
     switch(req->operation)
     {
         case WalletVersion:
             msg_buf[0] = SOLO_VERSION_MAJ;
-            msg_buf[0] = SOLO_VERSION_MIN;
-            u2f_response_writeback((uint8_t*)WALLET_VERSION, sizeof(WALLET_VERSION)-1);
+            msg_buf[1] = SOLO_VERSION_MIN;
+            u2f_response_writeback(msg_buf, 2);
             break;
         case WalletRng:
             printf1(TAG_WALLET,"SoloRng\n");
diff --git a/targets/stm32l432/src/app.h b/targets/stm32l432/src/app.h
index 8ffe43e..89011f5 100644
--- a/targets/stm32l432/src/app.h
+++ b/targets/stm32l432/src/app.h
@@ -36,7 +36,7 @@
 
 //#define USING_DEV_BOARD
 
-//#define ENABLE_U2F_EXTENSIONS
+#define ENABLE_U2F_EXTENSIONS
 
 #define ENABLE_U2F
 

From 72bca0765a054bfd5b38e4c682145d6dacb60140 Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Tue, 12 Feb 2019 15:11:48 -0500
Subject: [PATCH 05/10] see firmware version from solotool

---
 tools/solotool.py | 31 +++++++++++++++++++++++++------
 1 file changed, 25 insertions(+), 6 deletions(-)

diff --git a/tools/solotool.py b/tools/solotool.py
index 5148b50..7970baf 100755
--- a/tools/solotool.py
+++ b/tools/solotool.py
@@ -103,6 +103,9 @@ def get_firmware_object(sk_name, hex_file):
     msg = {'firmware': fw, 'signature': sig}
     return msg
 
+class SoloExtension:
+    version= 0x14
+    rng = 0x15
 
 class SoloBootloader:
     write = 0x40
@@ -209,10 +212,16 @@ class SoloClient:
 
         return res.signature[1:]
 
-    def version(self,):
+    def bootloader_version(self,):
         data = self.exchange(SoloBootloader.version)
+        if len(data) > 1:
+            return (data[0],data[1])
         return data[0]
 
+    def solo_version(self,):
+        data = self.exchange_u2f(SoloExtension.version)
+        return (data[0],data[1])
+
     def write_flash(self, addr, data):
         self.exchange(SoloBootloader.write, addr, data)
 
@@ -269,7 +278,7 @@ class SoloClient:
 
     def is_solo_bootloader(self,):
         try:
-            self.version()
+            self.bootloader_version()
             return True
         except CtapError as e:
             if e.code == CtapError.ERR.INVALID_COMMAND:
@@ -596,7 +605,7 @@ def solo_main():
     )
     parser.add_argument("--wink", action="store_true", help='HID Wink command.')
     parser.add_argument("--reset", action="store_true", help='Issue a FIDO2 reset command.  Warning: your credentials will be lost.')
-    parser.add_argument("--verify-solo", action="store_true", help='Verify that the Solo firmware is from SoloKeys.')
+    parser.add_argument("--verify-solo", action="store_true", help='Verify that the Solo firmware is from SoloKeys.  Check firmware version.')
     args = parser.parse_args()
 
     p = SoloClient()
@@ -617,12 +626,22 @@ def solo_main():
 
     if args.verify_solo:
         cert = p.make_credential()
+
         solo_fingerprint = b'r\xd5\x831&\xac\xfc\xe9\xa8\xe8&`\x18\xe6AI4\xc8\xbeJ\xb8h_\x91\xb0\x99!\x13\xbb\xd42\x95'
+        hacker_fingerprint = b"\xd0ml\xcb\xda}\xe5j\x16'\xc2\xa7\x89\x9c5\xa2\xa3\x16\xc8Q\xb3j\xd8\xed~\xd7\x84y\xbbx~\xf7"
 
         if (cert.fingerprint(hashes.SHA256()) == solo_fingerprint):
-            print('Valid firmware from SoloKeys')
+            print('Valid SOLO firmware from SoloKeys')
+        elif (cert.fingerprint(hashes.SHA256()) == hacker_fingerprint):
+            print('Valid HACKER firmware')
         else:
-            print('This is either a Solo Hacker or a invalid Solo.')
+            print('Unknown fingerprint! ', cert.fingerprint(hashes.SHA256()))
+
+        try:
+            v = p.solo_version()
+            print('Version: ', v)
+        except ApduError:
+            print('Firmware is out of date.')
 
 
 def asked_for_help():
@@ -922,7 +941,7 @@ def programmer_main():
         sys.exit(1)
 
     try:
-        p.version()
+        p.bootloader_version()
     except CtapError as e:
         if e.code == CtapError.ERR.INVALID_COMMAND:
             print('Bootloader not active.  Attempting to boot into bootloader mode...')

From 9957a83746fb7c6b000e9f9931bcb32a926f5787 Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Tue, 12 Feb 2019 16:03:04 -0500
Subject: [PATCH 06/10] organize makefiles

---
 targets/stm32l432/Makefile                   | 25 +++++++++++---------
 targets/stm32l432/{ => build}/application.mk |  0
 targets/stm32l432/{ => build}/bootloader.mk  |  0
 3 files changed, 14 insertions(+), 11 deletions(-)
 rename targets/stm32l432/{ => build}/application.mk (100%)
 rename targets/stm32l432/{ => build}/bootloader.mk (100%)

diff --git a/targets/stm32l432/Makefile b/targets/stm32l432/Makefile
index 017998f..9c23cec 100644
--- a/targets/stm32l432/Makefile
+++ b/targets/stm32l432/Makefile
@@ -2,30 +2,33 @@ ifndef DEBUG
 DEBUG=0
 endif
 
+APPMAKE=build/application.mk
+BOOTMAKE=build/application.mk
+
 merge_hex=python ../../tools/solotool.py mergehex
 
 all:
-	$(MAKE) -f application.mk -j8 solo.hex PREFIX=$(PREFIX) DEBUG=$(DEBUG) EXTRA_DEFINES='-DFLASH_ROP=1'
+	$(MAKE) -f $(APPMAKE) -j8 solo.hex PREFIX=$(PREFIX) DEBUG=$(DEBUG) EXTRA_DEFINES='-DFLASH_ROP=1'
 
 all-hacker:
-	$(MAKE) -f application.mk -j8 solo.hex PREFIX=$(PREFIX) DEBUG=$(DEBUG) EXTRA_DEFINES='-DSOLO_HACKER -DFLASH_ROP=0'
+	$(MAKE) -f $(APPMAKE) -j8 solo.hex PREFIX=$(PREFIX) DEBUG=$(DEBUG) EXTRA_DEFINES='-DSOLO_HACKER -DFLASH_ROP=0'
 
 all-locked:
-	$(MAKE) -f application.mk -j8 solo.hex PREFIX=$(PREFIX) EXTRA_DEFINES='-DFLASH_ROP=2'
+	$(MAKE) -f $(APPMAKE) -j8 solo.hex PREFIX=$(PREFIX) EXTRA_DEFINES='-DFLASH_ROP=2'
 
 debugboot-app:
-	$(MAKE) -f application.mk -j8 solo.hex DEBUG=2 PREFIX=$(PREFIX)\
+	$(MAKE) -f $(APPMAKE) -j8 solo.hex DEBUG=2 PREFIX=$(PREFIX)\
 	LDSCRIPT=linker/stm32l4xx_extra.ld EXTRA_DEFINES='-DAPPLICATION_START_PAGE=16 -DSOLO_HACKER'
 
 debugboot-boot:
-	$(MAKE) -f bootloader.mk -j8 bootloader.hex PREFIX=$(PREFIX) DEBUG=1 \
+	$(MAKE) -f $(BOOTMAKE) -j8 bootloader.hex PREFIX=$(PREFIX) DEBUG=1 \
 	LDSCRIPT=linker/bootloader_stm32l4xx_extra.ld EXTRA_DEFINES='-DAPPLICATION_START_PAGE=16 -DSOLO_HACKER'
 
 boot-sig-checking:
-	$(MAKE) -f bootloader.mk -j8 bootloader.hex PREFIX=$(PREFIX) DEBUG=0
+	$(MAKE) -f $(BOOTMAKE) -j8 bootloader.hex PREFIX=$(PREFIX) DEBUG=0
 
 boot-no-sig:
-	$(MAKE) -f bootloader.mk -j8 bootloader.hex PREFIX=$(PREFIX) EXTRA_DEFINES='-DSOLO_HACKER' DEBUG=0
+	$(MAKE) -f $(BOOTMAKE) -j8 bootloader.hex PREFIX=$(PREFIX) EXTRA_DEFINES='-DSOLO_HACKER' DEBUG=0
 
 build-release-locked: clean2 boot-sig-checking clean all-locked
 	$(merge_hex) solo.hex bootloader.hex all.hex
@@ -38,12 +41,12 @@ build-hacker: clean2 boot-no-sig clean all-hacker
 	$(merge_hex) solo.hex bootloader.hex all.hex
 
 clean:
-	$(MAKE) -f application.mk clean
-	$(MAKE) -f bootloader.mk clean
+	$(MAKE) -f $(APPMAKE) clean
+	$(MAKE) -f $(BOOTMAKE) clean
 clean2:
 	rm -f solo.hex bootloader.hex all.hex
-	$(MAKE) -f application.mk clean
-	$(MAKE) -f bootloader.mk clean
+	$(MAKE) -f $(APPMAKE) clean
+	$(MAKE) -f $(BOOTMAKE) clean
 
 
 flash: solo.hex bootloader.hex
diff --git a/targets/stm32l432/application.mk b/targets/stm32l432/build/application.mk
similarity index 100%
rename from targets/stm32l432/application.mk
rename to targets/stm32l432/build/application.mk
diff --git a/targets/stm32l432/bootloader.mk b/targets/stm32l432/build/bootloader.mk
similarity index 100%
rename from targets/stm32l432/bootloader.mk
rename to targets/stm32l432/build/bootloader.mk

From 020fe21546ace727e0bc2ee9312e791d7d991226 Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Tue, 12 Feb 2019 16:11:06 -0500
Subject: [PATCH 07/10] organize version header info

---
 targets/stm32l432/bootloader/bootloader.h |  8 ++------
 targets/stm32l432/src/app.h               | 10 ++++------
 targets/stm32l432/src/version.h           | 19 +++++++++++++++++++
 3 files changed, 25 insertions(+), 12 deletions(-)
 create mode 100644 targets/stm32l432/src/version.h

diff --git a/targets/stm32l432/bootloader/bootloader.h b/targets/stm32l432/bootloader/bootloader.h
index d12d953..0937abf 100644
--- a/targets/stm32l432/bootloader/bootloader.h
+++ b/targets/stm32l432/bootloader/bootloader.h
@@ -22,6 +22,7 @@
 #ifndef _APP_H_
 #define _APP_H_
 #include <stdint.h>
+#include "version.h"
 
 #define DEBUG_UART      USART1
 
@@ -65,12 +66,7 @@
 #define SKIP_BUTTON_CHECK_WITH_DELAY        0
 #define SKIP_BUTTON_CHECK_FAST              1
 
-
-#define BOOT_VERSION_MAJ    1
-#define BOOT_VERSION_MIN    0
-#define __STR_HELPER(x) #x
-#define __STR(x) __STR_HELPER(x)
-#define SOLO_PRODUCT_NAME "Solo Bootloader " __STR(BOOT_VERSION_MAJ) "." __STR(BOOT_VERSION_MIN)
+#define SOLO_PRODUCT_NAME "Solo Bootloader " VERSION
 
 void printing_init();
 void hw_init(void);
diff --git a/targets/stm32l432/src/app.h b/targets/stm32l432/src/app.h
index 89011f5..5a812ed 100644
--- a/targets/stm32l432/src/app.h
+++ b/targets/stm32l432/src/app.h
@@ -22,6 +22,7 @@
 #ifndef _APP_H_
 #define _APP_H_
 #include <stdint.h>
+#include "version.h"
 
 #define DEBUG_UART      USART1
 
@@ -43,15 +44,12 @@
 // #define DISABLE_CTAPHID_PING
 // #define DISABLE_CTAPHID_WINK
 // #define DISABLE_CTAPHID_CBOR
-#define SOLO_VERSION_MAJ    1
-#define SOLO_VERSION_MIN    0
-#define __STR_HELPER(x) #x
-#define __STR(x) __STR_HELPER(x)
+
 
 #if defined(SOLO_HACKER)
-#define SOLO_PRODUCT_NAME "Solo Hacker " __STR(SOLO_VERSION_MAJ) "." __STR(SOLO_VERSION_MIN)
+#define SOLO_PRODUCT_NAME "Solo Hacker " VERSION
 #else
-#define SOLO_PRODUCT_NAME "Solo " __STR(SOLO_VERSION_MAJ) "." __STR(SOLO_VERSION_MIN)
+#define SOLO_PRODUCT_NAME "Solo " VERSION
 #endif
 
 void printing_init();
diff --git a/targets/stm32l432/src/version.h b/targets/stm32l432/src/version.h
new file mode 100644
index 0000000..e9f2e7c
--- /dev/null
+++ b/targets/stm32l432/src/version.h
@@ -0,0 +1,19 @@
+#ifndef _VERSION_H_
+#define _VERSION_H_
+
+
+#ifndef SOLO_VERSION_MAJ
+
+#define SOLO_VERSION_MAJ    0
+#define SOLO_VERSION_MIN    0
+#define SOLO_VERSION_PATCH    0
+
+#endif
+
+#define __STR_HELPER(x) #x
+#define __STR(x) __STR_HELPER(x)
+
+#define VERSION     __STR(SOLO_VERSION_MAJ) "." __STR(SOLO_VERSION_MIN) "." __STR(SOLO_VERSION_PATCH)
+
+
+#endif

From bc8984aac3c7aaf25fd4345dbdea7e8e6959e780 Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Tue, 12 Feb 2019 16:37:09 -0500
Subject: [PATCH 08/10] pass version to gcc derived from git describe

---
 targets/stm32l432/build/application.mk |  7 ++-----
 targets/stm32l432/build/bootloader.mk  |  9 +++------
 targets/stm32l432/build/common.mk      | 19 +++++++++++++++++++
 targets/stm32l432/src/version.h        |  2 ++
 4 files changed, 26 insertions(+), 11 deletions(-)
 create mode 100644 targets/stm32l432/build/common.mk

diff --git a/targets/stm32l432/build/application.mk b/targets/stm32l432/build/application.mk
index acc3e48..8dd59b1 100644
--- a/targets/stm32l432/build/application.mk
+++ b/targets/stm32l432/build/application.mk
@@ -1,7 +1,4 @@
-CC=$(PREFIX)arm-none-eabi-gcc
-CP=$(PREFIX)arm-none-eabi-objcopy
-SZ=$(PREFIX)arm-none-eabi-size
-AR=$(PREFIX)arm-none-eabi-ar
+include build/common.mk
 
 # ST related
 SRC = src/main.c src/init.c src/redirect.c src/flash.c src/rng.c src/led.c src/device.c
@@ -46,7 +43,7 @@ endif
 DEFINES = -DDEBUG_LEVEL=$(DEBUG) -D$(CHIP) -DAES256=1  -DUSE_FULL_LL_DRIVER -DAPP_CONFIG=\"app.h\" $(EXTRA_DEFINES)
 # DEFINES += -DTEST_SOLO_STM32 -DTEST -DTEST_FIFO=1
 
-CFLAGS=$(INC) -c $(DEFINES)   -Wall -fdata-sections -ffunction-sections $(HW) -g
+CFLAGS=$(INC) -c $(DEFINES)   -Wall -fdata-sections -ffunction-sections $(HW) -g $(VERSION_FLAGS)
 LDFLAGS_LIB=$(HW) $(SEARCH) -specs=nano.specs  -specs=nosys.specs  -Wl,--gc-sections -u _printf_float -lnosys
 LDFLAGS=$(HW) $(LDFLAGS_LIB) -T$(LDSCRIPT) -Wl,-Map=$(TARGET).map,--cref -Wl,-Bstatic -ltinycbor
 
diff --git a/targets/stm32l432/build/bootloader.mk b/targets/stm32l432/build/bootloader.mk
index 3931dde..0849086 100644
--- a/targets/stm32l432/build/bootloader.mk
+++ b/targets/stm32l432/build/bootloader.mk
@@ -1,7 +1,4 @@
-CC=$(PREFIX)arm-none-eabi-gcc
-CP=$(PREFIX)arm-none-eabi-objcopy
-SZ=$(PREFIX)arm-none-eabi-size
-AR=$(PREFIX)arm-none-eabi-ar
+include build/common.mk
 
 # ST related
 SRC = bootloader/main.c bootloader/bootloader.c
@@ -44,9 +41,9 @@ endif
 DEFINES = -DDEBUG_LEVEL=$(DEBUG) -D$(CHIP) -DAES256=1  -DUSE_FULL_LL_DRIVER -DAPP_CONFIG=\"bootloader.h\" $(EXTRA_DEFINES)
 # DEFINES += -DTEST_SOLO_STM32 -DTEST -DTEST_FIFO=1
 
-CFLAGS=$(INC) -c $(DEFINES)   -Wall -fdata-sections -ffunction-sections $(HW) -g
+CFLAGS=$(INC) -c $(DEFINES)   -Wall -fdata-sections -ffunction-sections $(HW) -g $(VERSION_FLAGS)
 LDFLAGS_LIB=$(HW) $(SEARCH) -specs=nano.specs  -specs=nosys.specs  -Wl,--gc-sections  -lnosys
-LDFLAGS=$(HW) $(LDFLAGS_LIB) -T$(LDSCRIPT) -Wl,-Map=$(TARGET).map,--cref  -Wl,-Bstatic 
+LDFLAGS=$(HW) $(LDFLAGS_LIB) -T$(LDSCRIPT) -Wl,-Map=$(TARGET).map,--cref  -Wl,-Bstatic
 
 
 .PRECIOUS: %.o
diff --git a/targets/stm32l432/build/common.mk b/targets/stm32l432/build/common.mk
new file mode 100644
index 0000000..86469b3
--- /dev/null
+++ b/targets/stm32l432/build/common.mk
@@ -0,0 +1,19 @@
+CC=$(PREFIX)arm-none-eabi-gcc
+CP=$(PREFIX)arm-none-eabi-objcopy
+SZ=$(PREFIX)arm-none-eabi-size
+AR=$(PREFIX)arm-none-eabi-ar
+
+VERSION=$(shell git describe --abbrev=0 )
+VERSION_FULL=$(shell git describe)
+VERSION_MAJ=$(shell python -c 'print("$(VERSION)".split(".")[0])')
+VERSION_MIN=$(shell python -c 'print("$(VERSION)".split(".")[1])')
+VERSION_PAT=$(shell python -c 'print("$(VERSION)".split(".")[2])')
+
+VERSION_FLAGS= -DSOLO_VERSION_MAJ=$(VERSION_MAJ) -DSOLO_VERSION_MIN=$(VERSION_MIN) \
+	-DSOLO_VERSION_PATCH=$(VERSION_PAT) -DVERSION=\"$(VERSION_FULL)\"
+
+_all:
+	echo $(VERSION_FULL)
+	echo $(VERSION_MAJ)
+	echo $(VERSION_MIN)
+	echo $(VERSION_PAT)
diff --git a/targets/stm32l432/src/version.h b/targets/stm32l432/src/version.h
index e9f2e7c..ea97314 100644
--- a/targets/stm32l432/src/version.h
+++ b/targets/stm32l432/src/version.h
@@ -13,7 +13,9 @@
 #define __STR_HELPER(x) #x
 #define __STR(x) __STR_HELPER(x)
 
+#ifndef VERSION
 #define VERSION     __STR(SOLO_VERSION_MAJ) "." __STR(SOLO_VERSION_MIN) "." __STR(SOLO_VERSION_PATCH)
+#endif
 
 
 #endif

From 6c23532f08c9a064f21af31c0b66477182610558 Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Tue, 12 Feb 2019 16:37:32 -0500
Subject: [PATCH 09/10] use 3-byte version

---
 fido2/extensions/solo.c                   | 3 ++-
 targets/stm32l432/bootloader/bootloader.c | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/fido2/extensions/solo.c b/fido2/extensions/solo.c
index 32be8e4..6b36fe2 100644
--- a/fido2/extensions/solo.c
+++ b/fido2/extensions/solo.c
@@ -47,7 +47,8 @@ int16_t bridge_u2f_to_solo(uint8_t * _chal, uint8_t * _appid, uint8_t klen, uint
         case WalletVersion:
             msg_buf[0] = SOLO_VERSION_MAJ;
             msg_buf[1] = SOLO_VERSION_MIN;
-            u2f_response_writeback(msg_buf, 2);
+            msg_buf[2] = SOLO_VERSION_PATCH;
+            u2f_response_writeback(msg_buf, 3);
             break;
         case WalletRng:
             printf1(TAG_WALLET,"SoloRng\n");
diff --git a/targets/stm32l432/bootloader/bootloader.c b/targets/stm32l432/bootloader/bootloader.c
index d8a8b1b..161d21e 100644
--- a/targets/stm32l432/bootloader/bootloader.c
+++ b/targets/stm32l432/bootloader/bootloader.c
@@ -195,6 +195,8 @@ int bootloader_bridge(int klen, uint8_t * keyh)
             u2f_response_writeback(&version,1);
             version = BOOT_VERSION_MIN;
             u2f_response_writeback(&version,1);
+            version = BOOT_VERSION_PATCH;
+            u2f_response_writeback(&version,1);
             break;
         case BootReboot:
             printf1(TAG_BOOT, "BootReboot.\r\n");

From 45da2f0b329fb07b86e02c84bbbb9c077b616bc4 Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Tue, 12 Feb 2019 16:37:40 -0500
Subject: [PATCH 10/10] Update solotool.py

---
 tools/solotool.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/solotool.py b/tools/solotool.py
index 7970baf..5cbbb46 100755
--- a/tools/solotool.py
+++ b/tools/solotool.py
@@ -214,13 +214,13 @@ class SoloClient:
 
     def bootloader_version(self,):
         data = self.exchange(SoloBootloader.version)
-        if len(data) > 1:
-            return (data[0],data[1])
+        if len(data) > 2:
+            return (data[0],data[1],data[2])
         return data[0]
 
     def solo_version(self,):
         data = self.exchange_u2f(SoloExtension.version)
-        return (data[0],data[1])
+        return (data[0],data[1],data[2])
 
     def write_flash(self, addr, data):
         self.exchange(SoloBootloader.write, addr, data)