shimun/solo
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Merge pull request #180 from solokeys/test_pin_fixes

Browse Source 
Test pin fixes
This commit is contained in:
Conor Patrick 2019-04-23 19:58:44 -04:00 committed by GitHub
commit e0ce23034f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 38 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
tools/testing/tests/fido2.py
View File

@ -1009,8 +1009,8 @@ class FIDO2Tests(Tester):
key = res[1] key = res[1]
assert "Is public key" and key[1] == 2 assert "Is public key" and key[1] == 2
assert "Is P256" and key[-1] == 1 assert "Is P256" and key[-1] == 1
if key[3] != -7: assert "Is ALG_ECDH_ES_HKDF_256" and key[3] == -25
print("WARNING: algorithm returned is not for ES256 (-7): ", key[3])
assert "Right key" and len(key[-3]) == 32 and isinstance(key[-3], bytes) assert "Right key" and len(key[-3]) == 32 and isinstance(key[-3], bytes)
with Test("Test setting a new pin"): with Test("Test setting a new pin"):
@ -1069,9 +1069,45 @@ class FIDO2Tests(Tester):
self.testReset() self.testReset()
with Test("Test sending zero-length pin_auth, expect PIN_NOT_SET"):
self.testMC(
"Send MC request with new pin auth",
cdh,
rp,
user,
key_params,
other={"pin_auth": b"", "pin_protocol": pin_protocol},
expectedError=CtapError.ERR.PIN_NOT_SET,
)
self.testGA(
"Send MC request with new pin auth",
rp["id"],
cdh,
other={"pin_auth": b"", "pin_protocol": pin_protocol},
expectedError=CtapError.ERR.PIN_NOT_SET,
)
with Test("Setting pin code, expect SUCCESS"): with Test("Setting pin code, expect SUCCESS"):
self.client.pin_protocol.set_pin(pin1) self.client.pin_protocol.set_pin(pin1)
with Test("Test sending zero-length pin_auth, expect PIN_INVALID"):
self.testMC(
"Send MC request with new pin auth",
cdh,
rp,
user,
key_params,
other={"pin_auth": b"", "pin_protocol": pin_protocol},
expectedError=CtapError.ERR.PIN_INVALID,
)
self.testGA(
"Send MC request with new pin auth",
rp["id"],
cdh,
other={"pin_auth": b"", "pin_protocol": pin_protocol},
expectedError=CtapError.ERR.PIN_INVALID,
)
self.testReset() self.testReset()
with Test("Setting pin code >63 bytes, expect POLICY_VIOLATION "): with Test("Setting pin code >63 bytes, expect POLICY_VIOLATION "):
try: try: